search

acquia / blt

Acquia's toolset for automating Drupal 8 and 9 development, testing, and deployment.
https://docs.acquia.com/blt/
GNU General Public License v2.0
442 stars 394 forks source link

Guzzle 7 Breaks Run-server Command #4655

Closed yyss8 closed 1 year ago

yyss8 commented 1 year ago

Motivation

Fixes #4656 We noticed that the run-server command constantly fails on our Travis build after upgrading to Drupal 10. After looking into the code, we found that the exceptions used in the checkUrl method is no longer respected in Guzzle 7 and causing a client error to be thrown when curl returns a 404 response .

image

The option was deprecated in Guzzle 6 and was removed in 7 according to this PR https://github.com/guzzle/guzzle/pull/2464 (I don't see the option being marked deprecated anywhere)

Proposed changes

Switch to use the new option http_errors. The option was introduced in Guzzle 6, so it should be safe to use without changing anything in the composer.json file as Guzzle 6 was the minimum version required by Drupal 9.

Testing steps

  1. Set up a Drupal 10 site with BLT.
  2. Run blt tests:server:start -vvvv.
danepowell commented 1 year ago

Thanks for the PR!