search

acquia / blt

Acquia's toolset for automating Drupal 8 and 9 development, testing, and deployment.
https://docs.acquia.com/blt/
GNU General Public License v2.0
442 stars 394 forks source link

Replace abandoned composer package 'webmozart/path-util' #4670

Closed hkorik closed 1 year ago

hkorik commented 1 year ago

Motivation Fixes #4669 . As outlined in the projects deprecation notice this should be replaced with the symfony filesystem component.

Proposed changes Replaces the method used from the Path utility from webmozart/path-util with a replacement method from the symfony/filesystem component. Removes the composer direct dependency on the abandoned project.

Testing steps Ensure the blt internal:add-to-project command successfully adds custom blt related files to the expected .gitignore file within the configured project repo.root directory.

danepowell commented 1 year ago

Unfortunately, I don't think we can do this until Drupal 9 is EOL, since Drupal 9 requires Symfony 4 and the path utilities were only added to Symfony 5.

gaards commented 10 months ago

We are about a week away from D9 EOL, could this PR now be revisited/reopened/recreated?

https://www.drupal.org/about/core/policies/core-release-cycles/schedule

danepowell commented 10 months ago

Yes, we will revisit this in the near future

danepowell commented 10 months ago

Superseded by https://github.com/acquia/blt/pull/4706

@hkorik thanks for your PR; if you really want credit for this commit, let me know and I'll try to cherry-pick it into the new PR.