BLT-5215: UserConfig Class not found

acquia / blt

Acquia's toolset for automating Drupal 8 and 9 development, testing, and deployment.

https://docs.acquia.com/blt/

GNU General Public License v2.0

442 stars 394 forks source link

BLT-5215: UserConfig Class not found #4682

Open aneek opened 1 year ago

aneek commented 1 year ago

Describe the bug Certain libraries for example shelane/toggle-modules unable to find the Acquia\Blt\Robo\Common\UserConfig class.

To Reproduce Steps to reproduce the behavior, ideally starting from a fresh install of BLT:

Clone BLT repo.
Unable to find UserConfig.php inside src/Blt/Robo/Common directory. It was present on or before version 13.7.0.

Expected behavior Documentation explaning how to use UserConfig class.

joegl commented 1 year ago

The UserConfig class appears to have been removed in 13.7.1. I'm currently looking for release notes on how we should replace our implementations of UserConfig.

I don't see anything in the release notes here: https://github.com/acquia/blt/releases/tag/13.7.1

The 4 PR's linked here don't include the removal of the UserConfig class.
But if you compare 13.7.0 to 13.7.1 you can see it was removed.

joegl commented 1 year ago

I found the PR that removed the file: https://github.com/acquia/blt/pull/4643

It appears to be part of removing telemetry from BLT. I'm not sure why it wasn't included in the release notes.

danepowell commented 1 year ago

We removed telemetry in #4643. We removed UserConfig along with it since the UserConfig was only used to store telemetry preferences and we had no awareness of anyone extending the UserConfig class.

The UserConfig is basically just a wrapper around a Json file, it should be easy to replicate independently if you need it. You really just need the constructor and save() method.