search

acquia / blt

Acquia's toolset for automating Drupal 10 development, testing, and deployment.
https://docs.acquia.com/blt/
GNU General Public License v2.0
442 stars 394 forks source link

BLT-5224: Add back PHP code sniffing in pre-commit hook #4701

Closed brunodbo closed 9 months ago

brunodbo commented 10 months ago

PHP code sniffing was removed from the pre-commit hook in https://github.com/acquia/blt/commit/552ff157a6b6de3c11207ed505a4ea5ca7b7053e. Would it be possible to add it back? Unless there is a reason not to - it's unclear why it was removed, there is no issue referenced on the commit.

danepowell commented 9 months ago

Code sniffing was moved to a plugin, which is why it can't be part of the core commit hook: https://github.com/acquia/blt-phpcs

brunodbo commented 9 months ago

@danepowell That makes sense, closing this issue and associated PR. Thanks for the insight!