acquia / blt

Acquia's toolset for automating Drupal 8 and 9 development, testing, and deployment.
https://docs.acquia.com/blt/
GNU General Public License v2.0
442 stars 394 forks source link

PHP notice on every command execution after upgrading to PHP 7 CLI #995

Closed TravisCarden closed 7 years ago

TravisCarden commented 7 years ago

My system information:

Starting with a fresh BLT site, created today according to the documentation, I get the following before the output from every blt command:

PHP Notice:  A non well formed numeric value encountered in /Users/travis.carden/Sites/d8/vendor/phing/phing/classes/phing/Phing.php on line 1636

Notice: A non well formed numeric value encountered in /Users/travis.carden/Sites/d8/vendor/phing/phing/classes/phing/Phing.php on line 1636

The notice occurs in \Phing::convertShorthand(), where the value of the $val argument it's getting is string(4) "128M".

I recently updated my PHP CLI version to 7.1, which may account for the issue, since it's also happening on an older codebase that wasn't having the problem when I touched it last a month ago.

grasmash commented 7 years ago

Yeah this looks like an issue with Phing itself, and is likely specific to PHP 7.1.

TravisCarden commented 7 years ago

Hmm... Maybe you should consider gradually phasing out Phing. ;)

grasmash commented 7 years ago

Yeah.

I'm going to close this. Please open a Phing issue if you find this to be problematic.