search

acquia / cli

Acquia CLI
GNU General Public License v2.0
42 stars 47 forks source link

Make `acli app:new:from:drupal7` defer entirely to the recommendations #1590

Closed wimleers closed 12 months ago

wimleers commented 1 year ago

Motivation For historical reasons, the predecessor of acli app:new:from:drupal7 had to hardcode the package containing the AM:A Drupal module.

That is still there. It's never gotten in the way.

Until now.

Because config/from_d7_config.json is hardcoded to list acquia/acquia-migrate-accelerate in its project template, the recommendations that we will have at https://git.drupalcode.org/project/acquia_migrate/-/tree/recommendations will generate a project that continues to install the packagist/closed source AMA retrieved from GitHub instead of the open source AMA source retrieved from d.o’s packagist facade.

IOW, both of these will exist in the generated composer.json:

Clearly we shouldn't install the same module twice.

Proposed changes Remove acquia/acquia-migrate-accelerate from the template.

Alternatives considered /

Testing steps If the integration test still passes (which it will 👍 ), you'll know it's working correctly: because config/from_d7_recommendations.json is now the only place where acquia/acquia-migrate-accelerate is explicitly defined!

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (b2c6811) 91.76% compared to head (f81ded3) 91.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1590 +/- ## ========================================= Coverage 91.76% 91.76% Complexity 1809 1809 ========================================= Files 124 124 Lines 6471 6471 ========================================= Hits 5938 5938 Misses 533 533 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.