acquia / cli

Acquia CLI
GNU General Public License v2.0
45 stars 47 forks source link

Added prompt for php version for cs:wizard command #1594

Closed shubham-bansal96 closed 1 year ago

shubham-bansal96 commented 1 year ago

Motivation

Fixes # GL-1836

Proposed changes Add a prompt to choose php version between two of them. Either 8.1 or 8.2

Alternatives considered

Testing steps run command ./bin/acli cs:wizard and CLI should ask to choose PHP version. Once steps are completed then verify PHP_VERSION variable should get added to code studio UI.

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)
anavarre commented 1 year ago

Thanks for your contribution. Dane returns in mid-October. We'll look into finalizing and merging this then. Continue fixing tests and getting this as ready as can be in the interim!

codecov[bot] commented 1 year ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (553ff72) 91.76% compared to head (8f0be4a) 91.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1594 +/- ## ============================================ - Coverage 91.76% 91.68% -0.08% Complexity 1809 1809 ============================================ Files 124 124 Lines 6471 6485 +14 ============================================ + Hits 5938 5946 +8 - Misses 533 539 +6 ``` | [Files](https://app.codecov.io/gh/acquia/cli/pull/1594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=acquia) | Coverage Δ | | |---|---|---| | [src/Command/CodeStudio/CodeStudioCiCdVariables.php](https://app.codecov.io/gh/acquia/cli/pull/1594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=acquia#diff-c3JjL0NvbW1hbmQvQ29kZVN0dWRpby9Db2RlU3R1ZGlvQ2lDZFZhcmlhYmxlcy5waHA=) | `100.00% <100.00%> (ø)` | | | [src/Command/CodeStudio/CodeStudioWizardCommand.php](https://app.codecov.io/gh/acquia/cli/pull/1594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=acquia#diff-c3JjL0NvbW1hbmQvQ29kZVN0dWRpby9Db2RlU3R1ZGlvV2l6YXJkQ29tbWFuZC5waHA=) | `95.10% <100.00%> (+0.25%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/acquia/cli/pull/1594/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=acquia)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danepowell commented 1 year ago

Thanks, this mostly looks good. Just FYI, you could kill some of the mutants by improving the test cases.