search

acquia / cli

Acquia CLI
GNU General Public License v2.0
42 stars 47 forks source link

CLI-1136: [push:artifact] include empty directories and symlinks #1606

Closed danepowell closed 11 months ago

danepowell commented 11 months ago

Motivation

push:artifact doesn't mirror symlinks that point to directories. It probably also doesn't mirror empty directories, though that's less likely to cause problems since empty directories are VCS ignored and not generally useful anyway.

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (23d3e32) 91.68% compared to head (8d864c5) 91.68%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1606 +/- ## ========================================= Coverage 91.68% 91.68% Complexity 1809 1809 ========================================= Files 124 124 Lines 6485 6485 ========================================= Hits 5946 5946 Misses 539 539 ``` | [Files](https://app.codecov.io/gh/acquia/cli/pull/1606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=acquia) | Coverage Δ | | |---|---|---| | [src/Command/Push/PushArtifactCommand.php](https://app.codecov.io/gh/acquia/cli/pull/1606?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=acquia#diff-c3JjL0NvbW1hbmQvUHVzaC9QdXNoQXJ0aWZhY3RDb21tYW5kLnBocA==) | `90.66% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mglaman commented 10 months ago

@danepowell this is causing issues if a directory existed in the original artifact but was removed in the new artifact.

[2023-10-25T16:22:55.449Z]   [Symfony\Component\Finder\Exception\AccessDeniedException]                   
[2023-10-25T16:22:55.450Z]   RecursiveDirectoryIterator::__construct(/tmp/acli-push-artifact/acquia-util  
[2023-10-25T16:22:55.450Z]   s): Failed to open directory: No such file or directory
danepowell commented 10 months ago

Can you please open a new ticket (GitHub or Jira) with steps to reproduce? I don't understand why removing a directory would be any different than removing a file as far as the Symfony Finder is concerned.

mglaman commented 10 months ago

Yeah, I'll open a Jira ticket so I can explain in detail more