search

acquia / cli

Acquia CLI
GNU General Public License v2.0
42 stars 47 forks source link

CLI-1217: push:artifact should infer app id from env id #1633

Closed danepowell closed 10 months ago

danepowell commented 10 months ago

Motivation

I was trying to deploy code from a repo to a new application not already linked to that repo and was confused when it produced a Cloud API error because it was inferring the app id from .acquia-cli.yml rather than the more explicit env id.

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)
codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (79d271c) 91.93% compared to head (bdf9f5f) 91.93%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1633 +/- ## ========================================= Coverage 91.93% 91.93% - Complexity 1819 1821 +2 ========================================= Files 124 124 Lines 6509 6513 +4 ========================================= + Hits 5984 5988 +4 Misses 525 525 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.