search

acquia / cli

Acquia CLI
GNU General Public License v2.0
42 stars 47 forks source link

CLI-1225: The pull:database command fails silently if pv is not installed. #1641

Closed mdlutz24 closed 9 months ago

mdlutz24 commented 9 months ago

Motivation Fixes #1640: The pull:database command fails silently if pv is not installed

Proposed changes if pv is not installed, run gunzip with the -c flag so the decompressed output is piped to the mysql command

Alternatives considered There are other possible ways to manage output redirection in bash, this seemed simplest.

Testing steps On a system without pv installed set the appropriate ACLIDB**** environmental variables and execute an acli pull:database request. See the database downloaded and the command appear to succeed. Open the database and see that it is not empty.

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (436891f) 91.93% compared to head (525f165) 91.96%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1641 +/- ## ============================================ + Coverage 91.93% 91.96% +0.03% Complexity 1820 1820 ============================================ Files 124 124 Lines 6513 6513 ============================================ + Hits 5988 5990 +2 + Misses 525 523 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danepowell commented 9 months ago

Thanks for the PR!

mdlutz24 commented 9 months ago

Thanks for the PR!

Thanks for the test!