acquia / cli

Acquia CLI
GNU General Public License v2.0
42 stars 47 forks source link

CLI-1227: Implement PHP 8 attributes #1642

Closed danepowell closed 9 months ago

danepowell commented 9 months ago

I wanted to more radically strip configure() into attributes, but it turns out Symfony doesn't support that natively. The goal of AsCommand is only to replace static properties like the name and description, not all of the possible methods in configure().

Drush accomplishes this using consolidation annotated commands. It's a work of art, but I'd rather stick with pure Symfony patterns for now.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ef27522) 91.96% compared to head (b7ac970) 91.80%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1642 +/- ## ============================================ - Coverage 91.96% 91.80% -0.17% + Complexity 1820 1776 -44 ============================================ Files 124 122 -2 Lines 6513 6381 -132 ============================================ - Hits 5990 5858 -132 Misses 523 523 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.