acquia / cli

Acquia CLI
GNU General Public License v2.0
42 stars 47 forks source link

CLI-1245: Use REMOTEIDE_LABEL to bypass API call #1665

Closed danepowell closed 7 months ago

danepowell commented 7 months ago

Motivation

This API call is unnecessary. More importantly, it makes QA of IDE changes difficult because it's the only API call to the IDE endpoint associated with IDE creation.

Proposed changes

Use REMOTEIDE_LABEL instead of calling the API.

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Run ide:wizard in a new IDE, see that an SSH key is created successfully with the same label as before.
codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (682129a) 91.33% compared to head (f9d8536) 91.32%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1665 +/- ## ============================================ - Coverage 91.33% 91.32% -0.01% - Complexity 1784 1785 +1 ============================================ Files 122 122 Lines 6439 6434 -5 ============================================ - Hits 5881 5876 -5 Misses 558 558 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.