Closed akashkska closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.29%. Comparing base (
d7af9cf
) to head (e878acf
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@akashkska action item on you. Will you be able to work on the PR in the current sprint?
@akashkska action item on you. Will you be able to work on the PR in the current sprint?
yes working on same. There are some understanding gaps related to mutation testing so it is taking time to resolve .
To get you started, I recorded myself killing one of the mutants. Try replicating this process to kill a few more. You don't need to kill 100% of them, but get as many as you can.
https://github.com/acquia/cli/assets/1984514/101df98f-6753-4e79-ad27-ae5dbd24f823
To get you started, I recorded myself killing one of the mutants. Try replicating this process to kill a few more. You don't need to kill 100% of them, but get as many as you can.
Screen.Recording.2024-02-21.at.3.39.17.PM.mov
Is this correct recording ? I can see 3 sec recording.
Sorry, indeed it was the wrong recording. I reuploaded it.
@danepowell After latest commit No mutation warnings are shown in change log, also I see 2 mutants were killed. So does that mean PR is good to go in main ? If yes will you please approve and merge.
Sorry, sometimes the tests time out. I reran them and will increase the timeout in master
.
I think you'd only need to add 2-3 assertions to kill all or almost all of the mutants, like I did in the video. Please try it. It's not just busy work; the escaped mutants indicate the tests are not adequate, and I need to be able to rely on the tests in order to maintain this code.
Apologise @danepowell fix might be silly, to add valid assertions. But for me its taking time due to lack of expertise on php, as this is first time I am interacting with php codebase and testcases.
Dane is back at work today and will be able to further guide you on mutation testing. Good work thus far on addressing them.
Thanks for all of the work on this; it needs some stylistic cleanup but I can follow up with that (we should have codesniffer rules for these things).
Codestudio is introducing feature to create node js project separately, hence implemented prompt to choose type of project and respective flow for project creation.