search

acquia / cli

Command-line interface for Acquia Cloud Platform products
https://docs.acquia.com/acquia-cli/
GNU General Public License v2.0
42 stars 47 forks source link

CLI-1276: no-scripts doesn't disable composer hooks #1688

Closed danepowell closed 6 months ago

danepowell commented 6 months ago

Motivation

Fixes #1276

Proposed changes

Passing --no-scripts to any command that supports it will disable Composer command hooks.

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Run a command such as acli pull:code --no-scripts -v.
  4. Verify you don't see any messages in the output about composer scripts.
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6bc2749) 91.08% compared to head (b1607f2) 91.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1688 +/- ## ============================================ + Coverage 91.08% 91.09% +0.01% + Complexity 1786 1785 -1 ============================================ Files 122 122 Lines 6368 6367 -1 ============================================ Hits 5800 5800 + Misses 568 567 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.