search

acquia / cli

Command-line interface for Acquia Cloud Platform products
https://docs.acquia.com/acquia-cli/
GNU General Public License v2.0
42 stars 47 forks source link

CLI-1263: [ide:share] remove unnecessary API call #1689

Closed danepowell closed 6 months ago

danepowell commented 6 months ago

Motivation

This API call is unnecessary and hinders testing, let's simplify it.

Proposed changes Use env var instead.

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Check for regressions in acli ide:share
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6bc2749) 91.08% compared to head (cf09797) 91.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1689 +/- ## ========================================= Coverage 91.08% 91.08% - Complexity 1786 1787 +1 ========================================= Files 122 122 Lines 6368 6368 ========================================= Hits 5800 5800 Misses 568 568 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.