acquia / cli

Command-line interface for Acquia Cloud Platform products
https://docs.acquia.com/acquia-cli/
GNU General Public License v2.0
42 stars 47 forks source link

CLI-1293: [api:notifications:find] typeerror for sketchy notification strings #1705

Closed danepowell closed 5 months ago

danepowell commented 5 months ago

This is triggered if the notification string is valid Json but not a response object, i.e. \"5d811cb4-ac28-4ad2-a002-b0ff726e5040\".

Technically this is not supported, but on the off chance that something we told someone to do actually generated that escaped string, we might as well handle it gracefully.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.23%. Comparing base (5c73afc) to head (afb946f).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1705 +/- ## ========================================= Coverage 91.22% 91.23% - Complexity 1798 1799 +1 ========================================= Files 122 122 Lines 6452 6455 +3 ========================================= + Hits 5886 5889 +3 Misses 566 566 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.