Closed akashkska closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.41%. Comparing base (
72cdee2
) to head (5267acb
). Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @danepowell we tried debugging current issue, due to which testcases are failing but we were unable to find why executeFromCmd is returning null value:
TypeError: Double\Acquia\Cli\Helpers\LocalMachineHelper\P9::executeFromCmd(): Return value must be of type Symfony\Component\Process\Process, null returned
Whereas while executing functionality everything working fine.
That error is because you haven't mocked the localMachineHelper call. There's a thousand examples of how to mock this in the existing test cases; here's one from the Code Studio Wizard tests: https://github.com/acquia/cli/blob/f756e57ea0eac8af9a9ac519197ff5ef2c2da8e6/tests/phpunit/src/Commands/CodeStudio/CodeStudioWizardCommandTest.php#L344
Actually I did tried it but it didn't work hence didn't committed those changes. maybe I can commit those changes as well so that you guide what went wrong.
@akashkska this is a lot simpler using the GitLab PHP SDK. See my latest commit. Please test and confirm if this works for you.
yes it is working as expected.
DefaultCiPath was set to standard template for every project. whereas in node project CiPath should be set to newly created node-template.