acquia / cli

Command-line interface for Acquia Cloud Platform products
https://docs.acquia.com/acquia-cli/
GNU General Public License v2.0
42 stars 47 forks source link

GL-2368: Added node specific ciPath for node project. #1709

Closed akashkska closed 5 months ago

akashkska commented 5 months ago

DefaultCiPath was set to standard template for every project. whereas in node project CiPath should be set to newly created node-template.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.41%. Comparing base (72cdee2) to head (5267acb). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1709 +/- ## ========================================= Coverage 91.40% 91.41% Complexity 1800 1800 ========================================= Files 121 121 Lines 6458 6463 +5 ========================================= + Hits 5903 5908 +5 Misses 555 555 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

akashkska commented 5 months ago

Hi @danepowell we tried debugging current issue, due to which testcases are failing but we were unable to find why executeFromCmd is returning null value: TypeError: Double\Acquia\Cli\Helpers\LocalMachineHelper\P9::executeFromCmd(): Return value must be of type Symfony\Component\Process\Process, null returned Whereas while executing functionality everything working fine.

danepowell commented 5 months ago

That error is because you haven't mocked the localMachineHelper call. There's a thousand examples of how to mock this in the existing test cases; here's one from the Code Studio Wizard tests: https://github.com/acquia/cli/blob/f756e57ea0eac8af9a9ac519197ff5ef2c2da8e6/tests/phpunit/src/Commands/CodeStudio/CodeStudioWizardCommandTest.php#L344

akashkska commented 5 months ago

Actually I did tried it but it didn't work hence didn't committed those changes. maybe I can commit those changes as well so that you guide what went wrong.

danepowell commented 5 months ago

@akashkska this is a lot simpler using the GitLab PHP SDK. See my latest commit. Please test and confirm if this works for you.

akashkska commented 5 months ago

yes it is working as expected.