search

acquia / cli

Command-line interface for Acquia Cloud Platform products
https://docs.acquia.com/acquia-cli/
GNU General Public License v2.0
42 stars 45 forks source link

CLI-1182: Improve Phar visibility for PRs #1725

Closed danepowell closed 3 months ago

danepowell commented 3 months ago

Oh... right... this involves building untrusted code, hence pull_request instead of pull_request_target... but then we can't inject AWS credentials ☹️

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.42%. Comparing base (e175526) to head (bb5d6af).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1725 +/- ## ========================================= Coverage 91.42% 91.42% Complexity 1807 1807 ========================================= Files 121 121 Lines 6475 6475 ========================================= Hits 5920 5920 Misses 555 555 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danepowell commented 3 months ago

Unfortunately there's no way to test this without the code being merged to HEAD first, so let's move this conversation to HEAD...