search

acquia / cli

Acquia CLI
GNU General Public License v2.0
44 stars 47 forks source link

Normalize ah_env telemetry. #1742

Closed grasmash closed 4 months ago

grasmash commented 4 months ago

Motivation

Our ahv_env data has values like ode1, ode37, etc. These should be normalized.

Proposed changes

Normalize ah_env using provided methods from AcquiaDrupalEnvironmentDetector.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.74%. Comparing base (12e1dc5) to head (d5b33a8).

Files Patch % Lines
src/Helpers/TelemetryHelper.php 92.30% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1742 +/- ## ============================================ + Coverage 91.73% 91.74% +0.01% - Complexity 1810 1816 +6 ============================================ Files 121 121 Lines 6506 6518 +12 ============================================ + Hits 5968 5980 +12 Misses 538 538 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 months ago

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1742/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1742/acli.phar
chmod +x acli.phar
danepowell commented 4 months ago

This and a lot of the previous PR should really go in the environment detector, but it's not something I have time to handle at the moment.