Closed PrakharJainS3 closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.75%. Comparing base (
a845434
) to head (5d215b3
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1764/acli.phar
curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1764/acli.phar
chmod +x acli.phar
Typically, Node versions are updated quite frequently upstream. It means you're gonna have to change the versions in ACLI equally often and get a new release out accordingly. Do we not have something more sustainable with less toil to envision?
That is what we are aiming for using these changes. So previously we had minor as well as patch version selected by user in the CLI, but now we will only provide the option to select the major version which changes in a long time. We will manage the precise version to be selected by us in the background that can be changed by the user later if needed.
Believe it or not, I actually looked at the diff the other way around. All good!
Looks good except for the failing mutation test. It's telling you that tests still pass when Node 18 is removed from the available options. Looks like you need to add/improve the test for Node 18.
Note that the coding standards on this project changed dramatically since you opened this PR. You'll need to rebase or merge on master, and it might be easier to just start a new PR.
Will open a new PR.
Motivation
The current values provided in NODE_VERSION need to be update as for better onboarding flow to user on Node Project. Also the default value for the select needed to be changed.
Testing steps
Following steps can be taken to verify the changes:
acli cs:wizard
.