acquia / cli

Acquia CLI
GNU General Public License v2.0
42 stars 47 forks source link

GL-2753 : CS Wizard updated node version select values #1767

Closed PrakharJainS3 closed 2 months ago

PrakharJainS3 commented 2 months ago

Motivation

The current values provided in NODE_VERSION need to be update as for better onboarding flow to user on Node Project. Also the default value for the select needed to be changed.

Testing steps

Following steps can be taken to verify the changes:

github-actions[bot] commented 2 months ago

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1767/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1767/acli.phar
chmod +x acli.phar
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.99%. Comparing base (285ba09) to head (9780a66).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1767 +/- ## ============================================ + Coverage 91.92% 91.99% +0.07% Complexity 1818 1818 ============================================ Files 121 121 Lines 6834 6834 ============================================ + Hits 6282 6287 +5 + Misses 552 547 -5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

shriacquia commented 2 months ago

@danepowell - would you be able to release this change? GL-2653 depends on this update.

danepowell commented 2 months ago

https://github.com/acquia/cli/releases/tag/2.28.1