CLI-1362: [push:db] mysqldump failure not surfaced - Githubissues

acquia / cli

Acquia CLI

GNU General Public License v2.0

42 stars 47 forks source link

CLI-1362: [push:db] mysqldump failure not surfaced #1770

Closed danepowell closed 1 month ago

danepowell commented 1 month ago

Turns out we aren't the first ones to have this problem: https://github.com/drush-ops/drush/issues/3816

If Drush does it this way, it's good enough for me! 😄

Testing steps:

Set max_allowed_packet extremely low, or import a db with huge row sizes
Run push:db -vvv

Before this PR, see that the push continues past the local dump despite an error about packet size. After this error, see that the push stops with the following exception:

In CommandBase.php line 1703:

  [Acquia\Cli\Exception\AcquiaCliException]       
  Unable to create a dump of the local database.

github-actions[bot] commented 1 month ago

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1770/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1770/acli.phar
chmod +x acli.phar

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.02%. Comparing base (56d0139) to head (b94a3ae).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1770 +/- ## ============================================ + Coverage 91.99% 92.02% +0.02% Complexity 1818 1818 ============================================ Files 121 121 Lines 6834 6834 ============================================ + Hits 6287 6289 +2 + Misses 547 545 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.