acquia / cli

Acquia CLI
GNU General Public License v2.0
42 stars 47 forks source link

CLI-1377 Delay API lookup of application by ID #1781

Closed mglaman closed 6 days ago

mglaman commented 3 weeks ago

Motivation Fixes CLI-1377

Proposed changes We are passing destination URLs and other required parameters to an application which isn't accessible over the API and doesn't need to be given the provided params

Alternatives considered Fake the ID

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)
danepowell commented 1 week ago

@mglaman are you able to fix the test cases for this?

mglaman commented 1 week ago

@danepowell yeah, it fell off my radar, thanks for the ping!

github-actions[bot] commented 1 week ago

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1781/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1781/acli.phar
chmod +x acli.phar
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.22%. Comparing base (9960580) to head (35fbec0). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1781 +/- ## ========================================= Coverage 92.22% 92.22% Complexity 1817 1817 ========================================= Files 121 121 Lines 6813 6814 +1 ========================================= + Hits 6283 6284 +1 Misses 530 530 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mglaman commented 1 week ago

sorry for commit spam, couldn't run tests locally

danepowell commented 6 days ago

Thanks for the PR!