acquia / cli

Acquia CLI
GNU General Public License v2.0
42 stars 47 forks source link

CLI-1389: "push:artifact" command has support for multiple git urls using acli config file but not supported in file. #1788

Closed joshirohit100 closed 5 days ago

joshirohit100 commented 1 week ago

acli push:artifact command supports multiple git urls and as per https://github.com/acquia/cli/blob/main/src/Command/Push/PushArtifactCommand.php#L164 config can be done using acli config file (acquic-cli.yml) but looks like code for this is not supported as AcquiaCliConfig only supports one key cloud_app_uuid

https://github.com/acquia/cli/blob/main/src/Config/AcquiaCliConfig.php#L23

This is my sample acli config file -

cloud_app_uuid: APPIDHERE
push:
  artifact:
    destination_git_urls:
      - GITURL1HERE
      - GITURL2HERE
joshirohit100 commented 1 week ago

to fix this -

$treeBuilder
            ->getRootNode()
                ->children()
                    ->scalarNode('cloud_app_uuid')->end()
                    ->arrayNode('push')
                        ->children()
                            ->arrayNode('artifact')
                                ->children()
                                    ->arrayNode('destination_git_urls')
                                        ->scalarPrototype()->end()
                                    ->end()
                                ->end()
                            ->end()
                        ->end()
                    ->end()
                ->end();
joshirohit100 commented 1 week ago

pull request for ref - https://github.com/acquia/cli/pull/1789