search

acquia / cli

Acquia CLI
GNU General Public License v2.0
45 stars 47 forks source link

CLI-1397: Exception on local non-RSA SSH keys #1802

Closed danepowell closed 1 month ago

danepowell commented 1 month ago

Motivation

Fixes CLI-1397

Proposed changes

Remove the check for RSA keys

It looks like this was added in #1501 because we simply copied the code from the upstream library: https://github.com/violuke/rsa-ssh-key-fingerprint/blob/master/src/violuke/RsaSshKeyFingerprint/FingerprintGenerator.php

But I can't see any reason to restrict that code to RSA keys. You can run sha256 on any key 🤷

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. (add specific steps for this pr)
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.24%. Comparing base (6482891) to head (c3671ca). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1802 +/- ## ============================================ + Coverage 92.23% 92.24% +0.01% + Complexity 1818 1817 -1 ============================================ Files 121 121 Lines 6825 6823 -2 ============================================ - Hits 6295 6294 -1 + Misses 530 529 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danepowell commented 1 month ago

Test failure is unrelated