search

acquia / coding-standards-php

PHP_CodeSniffer rules (sniffs) for Acquia coding standards
GNU General Public License v2.0
19 stars 13 forks source link

Add rule to enforce mixing variable cases in AcquiaDrupalStrict #19

Open balsama opened 3 years ago

balsama commented 3 years ago

There doesn't seem to be any enforcement of mixing snake_case for variable names with lowerCamelCase. (For example, the following variable passed PHPCS: $commit_messageFailedPatches)

Can we add something to enforce one or the other (no mixing)?

Side note: I was surprised that Drupal coding standards don't dictate one or the other:

Variables should be named using lowercase, and words should be separated either with uppercase characters (example: $lowerCamelCase) or with an underscore (example: $snake_case). Be consistent; do not mix camelCase and snake_case variable naming inside a file.

🤷‍♀️

TravisCarden commented 3 years ago

Thanks, @balsama. I'm surprised to find that the Drupal coding standards don't dictate one or the other, too! They used to--and Coder used to enforce them. The best thing I could find about it on d.o is this: Allow camelCase for variable naming conventions [#2303963]. But that's a very old issue. In any case, this does seem like it should be solved in Coder module since the official standards do seem to dictate "one or the other". Would you care to create an issue there?

danepowell commented 2 years ago

I took the liberty of opening an upstream issue: https://www.drupal.org/project/coder/issues/3244409