search

acquia / coding-standards-php

PHP_CodeSniffer rules (sniffs) for Acquia coding standards
GNU General Public License v2.0
19 stars 13 forks source link

Fix #18: Correct extensions not scanned, allow extensions to be overridden #27

Closed danepowell closed 2 years ago

danepowell commented 2 years ago

Fixes #18 by removing the list of extensions to scan from our rulesets. Users must now specify the extensions to scan via the --extensions arg or in phpcs.xml.

I think this should be part of a minor release, since the effects of the breaking change are identical to the bug being fixed (i.e. .module files silently failing to be scanned). The release notes just need to call out this change and the need to manually specify extensions going forward.

wu-edward commented 2 years ago

@danepowell I just tested as a patch to my BLT 13 project, and now module files are sniffed as expected.

I don't have an opinion on whether it's a minor release, as I can see issues either way.