search

acquia / coding-standards-php

PHP_CodeSniffer rules (sniffs) for Acquia coding standards
GNU General Public License v2.0
19 stars 13 forks source link

Update minimum PHP version for PHPCompatibility sniff to 7.4 #37

Closed TravisCarden closed 2 years ago

TravisCarden commented 2 years ago

Acquia Cloud no longer support PHP 7.3. This change drops the PHPCompatibility requirement for it and raises the minimum version to 7.4. No change is needed for the update to take effect. If you want to add the check back (or change it to anything else), you may do so with a change like this to your configuration file:

 <ruleset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="vendor/squizlabs/php_codesniffer/phpcs.xsd"
 >
-  <rule ref="AcquiaPHP"/>
+  <rule ref="AcquiaPHP">
+    <exclude name="PHPCompatibility"/>
+  </rule>
+  <config name="testVersion" value="7.4-"/>
+  <rule ref="PHPCompatibility">
+    <exclude name="PHPCompatibility.Extensions.RemovedExtensions.famRemoved"/>
+  </rule>
 </ruleset>

Fixes: https://github.com/acquia/coding-standards-php/issues/36

danepowell commented 2 years ago

Looks like tests are broken, I'll attempt to fix them in https://github.com/acquia/coding-standards-php/pull/38