search

acquia / df

Demo Framework - mirrored at https://git.drupal.org/project/df.git
https://www.drupal.org/project/df
18 stars 19 forks source link

LB - content/media embed not working #113

Closed rlnorthcutt closed 5 years ago

rlnorthcutt commented 5 years ago

When trying to add a content/media embed block, it spins and no block is added. We need to fix this in the module, or find an alternative.

kevinfunk commented 5 years ago

I have found success embedding content/media using Entity Browser -> Browser for Content and Entity Browser -> Media browser. It's not intuitive, but it works.

saltednut commented 5 years ago

Is there a way we can make that flow more intuitive? I wonder if this issue blocks the alpha or if we should move it to the next milestone.

saltednut commented 5 years ago

I know it might seem weird but one thing that would simplify this is if we remove the block_content.type.media from df_tools_blocks - this would force people to embed content the other way.

saltednut commented 5 years ago

Ah okay nm I see whats going on here. So there's just way too many options on the sidebar and this is really in some ways a sub-issue of #114 . We need to file feedback issues detailing that this doesn't work, but in the meantime we should work out #114 and how we're going to handle it - my take is that we should look at following through with this: https://www.drupal.org/project/block_blacklist/issues/3055871

kevinfunk commented 5 years ago

Commit b5cfefe fixes Content Embed and commit f6e4796 fixes Media Embed.