One needs to Edit media from the "Grid" view

acquia / df

Demo Framework - mirrored at https://git.drupal.org/project/df.git

https://www.drupal.org/project/df

18 stars 19 forks source link

One needs to Edit media from the "Grid" view #128

Closed saltednut closed 5 years ago

saltednut commented 5 years ago

It seems weird that one can click on media in the grid but can only perform bulk operations. Each Media item in the view should have an edit link, similar to the table view. Shown: Media library grid in DF (Material Admin theme)

Shown: Table view has the "Edit" action.

saltednut commented 5 years ago

We'd prefer not to override the view if it is coming from Lightning or core. Seems like something everyone could use?

saltednut commented 5 years ago

Lightning also affected by this, so we should look at the media browser and see what we can do maybe. @balsama do you have an opinion here? I can file a PF or w/e but maybe there's already plan already in place?

balsama commented 5 years ago

The ML view should provide a link to the media entity edit page too. The top half/preview portion selects for bulk operations and the name below links to the entity edit page.

Maybe DFs theme is iterfering with that? Just speculating. You can test in Lightning's sandbox here: https://lightning.acquia.com/lightning (admin/admin)

Example gif: ml-link-2

saltednut commented 5 years ago

Thanks, @balsama - I see it now in my Lightning install.

You're right - it looks like DF is stripping the edit link. We'll investigate and resolve on our end.

kevinfunk commented 5 years ago

Our template is coming from Material Admin Support.

balsama commented 5 years ago

Related, have you tried Claro yet? They haven't gotten to the Media Library yet but it's in their roadmap. https://www.drupal.org/project/claro/issues/3062751

saltednut commented 5 years ago

Yep we have started including it in our build (Claro) but its not turned on by default. Looks like Media and Views still need work. Its very vanilla looking to me but perhaps if someone adds color module integration it will be more appealing.

saltednut commented 5 years ago

This looks good as of 1308e95ad4da0095cbe495ce785fc674c8fd443b thanks @kevinfunk