search

acquia / df

Demo Framework - mirrored at https://git.drupal.org/project/df.git
https://www.drupal.org/project/df
18 stars 19 forks source link

Replace any existing Image fields on node bundles to use Media Image entity references #137

Closed kevinfunk closed 5 years ago

kevinfunk commented 5 years ago

Images should be added as a Media reference with a widget of Entity Browser. The Entity browser should be Media browser (Modal). Display Edit button, Display Remove button, and Show widget details as open by default should be selected. The selection mode should be Append to selection and the view mode should be Thubnail. image image

saltednut commented 5 years ago

Images should be added as a Media reference with a widget of Entity Browser

Where?

saltednut commented 5 years ago

This needs a more specific title too. I am not sure what you're proposing here.

rlnorthcutt commented 5 years ago

I believe this is not necessarily about a specific field, but more about making this the new standard and making sure we have consistency. I altered the title to show that we need to "audit" the codebase to be sure all image fields are now media fields in our entities.

saltednut commented 5 years ago

So this is really just looking at the content types (node bundles) and determining if there are any image fields being used? We don't have any other entity types that would use an image. You have to have an image field on the media (media:image bundle) so just searching the codebase for all image fields is not specific enough. I would prefer, rather than adding "audit" we have a real direction.

kevinfunk commented 5 years ago

Ron's correct, this was more about documentation.

kevinfunk commented 5 years ago

I've updated the Banner image to use a modal to provide a similar experience and I've put in a ticket for Lightning to change the Banner image to a media entity. Since everything we have control over uses a media image, I'm going to close this issue.