search

acquia / df

Demo Framework - mirrored at https://git.drupal.org/project/df.git
https://www.drupal.org/project/df
18 stars 19 forks source link

Patch audit #140

Open rlnorthcutt opened 5 years ago

rlnorthcutt commented 5 years ago

We need to run a patch audit of all patches in DF:

Also - this should be a regularly recurring task. Quarterly?

saltednut commented 5 years ago

Do you wish to include patches that come from Lightning as well, or just patches that are in DF? Where do we want this audit to happen? This is assigned to Kevin but it has no action items. I don't see a lot of value in tracking a spreadsheet that will just be a mirror of what's in the composer file here: https://github.com/acquia/df/blob/8.x-4.x/composer.json#L74-L101

Unless there's some reason to track it there - perhaps additional rows to track status or ownership of someone outside our team? If this is just because people are saying "lets us know what core patches you're using so we can work on them" then the list is always here: https://github.com/acquia/df/blob/8.x-4.x/composer.json#L74-L101

rlnorthcutt commented 5 years ago

Gotcha. I think a spreadsheet with status and ownership is a great idea. This came about because Mike was asking about some of our patches, and he had some examples where the issue was closed/won't fix... so we have at least one or two patches that are orphaned.

We need to have a regular audit of patches to see that status of the parent, if/when they are applied, and then to help us determine if we need to ask for help getting patches accepted. Once we have this going, it shouldn't be too tough to keep it updated on a quarterly basis.

saltednut commented 5 years ago

We need to have a regular audit of patches to see that status of the parent, if/when they are applied, and then to help us determine if we need to ask for help getting patches accepted.

If that's the case, I don't think this is an appropriate ticket for a milestone that ends on the 15th as this effort will never end.

saltednut commented 5 years ago

Totally cool with leaving this open but lets move it off the milestone and just revisit it periodically?

kevinfunk commented 5 years ago

Reasons for removing the patch, "Support Outside In navbar changes with new quickedit button styling." The maintainer of Adminimal Admin Toolbar was not able to figure out what was being changed with the patch and closed the issue. Looking at the DOM, I was not able to find a scenario with the class toolbar-icon-edit which is targeted in the patch.

saltednut commented 4 years ago

We need to revisit this to see if there's any additional patches we should update or remove as a part of this branch https://github.com/acquia/df/tree/8.x-4.x-patches