search

acquia / df

Demo Framework - mirrored at https://git.drupal.org/project/df.git
https://www.drupal.org/project/df
18 stars 19 forks source link

PS module audit #158

Open rlnorthcutt opened 5 years ago

rlnorthcutt commented 5 years ago

Mike Madison has done an audit of our old DF module list to see what they might want to pull into their distro. He highlighted a few modules that have weak/limited support that we should check out to see if we can replace them, remove them, or pull their functionality into a df_tool module:

1) better_formats - this doesn't have a stable release and has been neglected. Suggested to look at allowed_formats as a possible replacement. We may want to create a patch for any additional features from better_formats.

2) content_browser - I know that this is smortyware, and I am inclined to keep it. But, if this just provides some presets for entity_browser, maybe we should just have config? What else does this provide? Should we update and create a stable version?

3) image_effects - How are we using this in DF now? Do we need it? I don't recall any SAs needing this kind of functionality, so maybe we just don't need it anymore? If so - could we just grab the one or two image style plugins and put them in a custom df_tools module?

4) message & message_notify - Again, how are we using this in DF now? Do we really need it? Can we simplify or streamline things?

5) replicate - This seems to be unmaintained and has an issue suggesting deprecation in favor of entity_clone. PS also suggests entity_clone. I think we need to test both and see if either has a better experience, otherwise we should move to a more supported module.

Source: https://docs.google.com/spreadsheets/d/1GUN-b_6k2iHtONh27nx7wv_hGvnoa0D2PGZQ5LCmP20/

kevinfunk commented 4 years ago

Entity Blocks looks like another module we might be able to remove.

saltednut commented 4 years ago

Is it used by any 4.x Scenario?

kevinfunk commented 4 years ago

I know it's not used in One. I don't think Gol or Default use it, but I'll check.

kevinfunk commented 4 years ago

message & message_notify - Again, how are we using this in DF now? Do we really need it? Can we simplify or streamline things?

I think it is safe to remove them. They were require by df_tools_message and it was removed in 4.x.

kevinfunk commented 4 years ago

Entity Blocks looks like another module we might be able to remove.

Entity Blocks is coming from Lightning Layout. We are patching it to provide UUID support. I'll test to see with the patch is needed for Default Content if someone would need to use Entity Blocks.