search

acquia / df

Demo Framework - mirrored at https://git.drupal.org/project/df.git
https://www.drupal.org/project/df
18 stars 19 forks source link

Adding Pendo integration. #189

Open grasmash opened 4 years ago

grasmash commented 4 years ago

This is a quick and dirty PR to illustrate how to integrate Pendo with DF.

I intend to publish the Pendo module to Drupal.org as a generic module. The Acquia Pendo module should be kept private.

grasmash commented 4 years ago

@rlnorthcutt @japerry May be interested in this.

japerry commented 4 years ago

Yup, in general we shouldn't be bringing the code in like this. And it looks like you've already posted it to https://www.drupal.org/project/pendo which is great. Can I get access to that project?

grasmash commented 4 years ago

@japerry sure. I've made you a maintainer.

saltednut commented 4 years ago

If you'd like to redo this one as a PR against the composer file we'll slurp it in with all the other acquia_ stuff

grasmash commented 4 years ago

I can redo the pull request so that the Pendo module is downloaded from Drupal.org. However, the acquia_pendo module should remain private. Where should that be committed?

japerry commented 4 years ago

@grasmash why should acquia_pendo remain private? It seems to be providing pendo integration for Drupal sites hosted on the Acquia platform. It seems like this too would be good to be available for not just our products using Drupal+Pendo but any of our customers as well.

Maybe have a subfolder inside the pendo module that offers up integrations? Pantheon customers would want to have their own customization when pendo is installed on their platform. And maybe as an alternative to that, we could just integrate the preprocess as an event subscriber so it'd just automatically work without needing to enable extra modules.

saltednut commented 4 years ago

We have a whole library of private stuff I'll dm you Matt

saltednut commented 4 years ago

Is this still an initiative?

rlnorthcutt commented 4 years ago

Just to touch base on this again, acquia/df is the open source version of Demo Framework, so it should only include open source code.

On the other hand, acquia/demo_framework is our proprietary version of DF which allows us to add things like API keys, etc.

So, what do we need to be secret, and why? If we want to offer DF as an option for free tier with Pendo built in, then that would need to be open source anyway - they will have access to the codebase.