search

acquia / df

Demo Framework - mirrored at https://git.drupal.org/project/df.git
https://www.drupal.org/project/df
18 stars 19 forks source link

Fix "Map" block type and add basic tests for Hero and Map types #19

Closed mortenson closed 8 years ago

mortenson commented 8 years ago

This PR adds two new tests for our more complicated blocks, with the idea that in the future all of our blocks will have coverage. Since the Slideshow, Media, and Content Block types are going to change soon, I have not added tests for those. When they are refactored tests will be added.

I've also ported a previously private module to df_tools_map, which includes the Map block type and plugins that can be used to geocode and filter content that uses geofields.

mortenson commented 8 years ago

@brantwynn Where should these tests live? DF as a profile doesn't require df_tools_blocks, so tests will never pass in the main scenario.

saltednut commented 8 years ago

@mortenson maybe we should just enable df_tools_blocks with df_admin?

mortenson commented 8 years ago

To test all the blocks, we would have to also enable df_tools_slideshow and df_tools_map. There could be other optional modules in df as well, so I'm not sure what our best practice is for enabling those.

saltednut commented 8 years ago

I think these blocks, the map and slideshow are all pretty critical to the demos and we need to be testing them all at this low level. Go for it.