search

acquia / df

Demo Framework - mirrored at https://git.drupal.org/project/df.git
https://www.drupal.org/project/df
18 stars 19 forks source link

Adds seed derivatives command & UI #35

Closed typhonius closed 7 years ago

typhonius commented 7 years ago

@brantwynn I think I've fixed the user interface so this can now be used to create derivatives if the user does not have access to Drush.

saltednut commented 7 years ago

For the drush command, it does work. The count does not initially, so it says " entries are to have their image derivatives created." with the variable string missing. Also tested via UI and that works.

As I said before, I'd like to see the .module turned into a proper service, but thats not really a blocker for merging. We should definitely fix the permissions declaration as it currently says "administer auto login url" - thanks!

typhonius commented 7 years ago

Thanks @brantwynn for the advice about making this a service. Definitely something I'd be keen to learn more about. I've fixed the drush output, the permissions name and added in checkboxes. If you'd like me to collapse this all into a single commit, I'm happy to do that.

saltednut commented 7 years ago

@typhonius np. We can merge this in as-is and if you have time we can chat about services and do a follow up PR later. I can squash it on your behalf and merge, but its up to you. This looks good on my end though. @briancwald did you want to do a quick run through?