search

acquia / df

Demo Framework - mirrored at https://git.drupal.org/project/df.git
https://www.drupal.org/project/df
18 stars 19 forks source link

Simplify the Hero form and add basic styling #43

Closed mortenson closed 7 years ago

mortenson commented 7 years ago

This PR is ready to be looked at, but I'd like input from @briancwald about what styling needs to be supported before committing this work. So far the only changes are:

  1. Remove the fieldsets from the form, and move advanced elements like the nested block and icon to the "Advanced" section.
  2. Do a lot of form cleanup to simplify elements, including patching Entity Browser to not use a table for displaying single-cardinality Image fields.
  3. Added a field to change alignment, which required adding some theme-agnostic CSS to df_tools_block.
  4. Added a field to change text color, using the browser's built in Color picker.

We can go pretty crazy with styles, but some that may be useful to add are:

  1. Gradient/background color - take the white gradient out of the Image Style for heroes and put it into CSS like it was in Drupal 7, and let users change the gradient color.
  2. Callout link color - this could also be controlled globally in colors.css, so instead of doing a free-form color field we could follow Foundation's standard and just allow success, secondary, alert, and info.
  3. Font size and family - I'm against this but the feature has been requested multiple times.

Any thoughts?

briancwald commented 7 years ago

We can go pretty crazy with styles, but some that may be useful to add are:

Agree on 1 and 2.

Point 3, we should allow font size changes, but NOT font family.

mortenson commented 7 years ago

I've implemented callout and gradient color, but not font size changes. Thinking about it more, I would rather just get what we had in D7 in, then add more styles as they're requested. Plus configuring font size (by pixel) has issues with mobile support, and as a user I felt weird not being able to change the font style and weight as well.

briancwald commented 7 years ago

Functionally this works well! the UX and design needs a fair bit of work before we can merge. I will focus on this when I can.

saltednut commented 7 years ago

I think we can commit this once the merge conflicts are resolved.