search

acquia / df

Demo Framework - mirrored at https://git.drupal.org/project/df.git
https://www.drupal.org/project/df
18 stars 19 forks source link

Added the views_block_filter_block to df_tools_blocks #48

Closed saltednut closed 7 years ago

saltednut commented 7 years ago

I think the overrides they do to Views might still be a little too loose even after this patch but unsure where to debug the usesExposedFormInBlock() override.

Perhaps we could also add to the patch with a check here http://cgit.drupalcode.org/views_block_filter_block/tree/src/Plugin/views/vbfbPluginDisplayBlock.php?h=8.x-1.x#n31 ?

Or maybe it doesn't matter.

mortenson commented 7 years ago

In my testing, the patch from https://www.drupal.org/node/2681947#comment-11726095 also allows this to work and doesn't require the contrib module/patch. Would it be acceptable to just patch core to allow this?

saltednut commented 7 years ago

Lets switch to the core patch. Can you update the PR and I'll test it?

mortenson commented 7 years ago

PR is ready for review (again).

saltednut commented 7 years ago

Kind of forcing this in but it resolves some pretty big site building issues with such a small change I think we're good.