search

acquia / df

Demo Framework - mirrored at https://git.drupal.org/project/df.git
https://www.drupal.org/project/df
18 stars 19 forks source link

Issue #69 - Refactoring Magellan javascript: make magellan frontend-agnostic #70

Closed zolhorvath closed 6 years ago

zolhorvath commented 6 years ago

This PR refactors Magellan javascript (fixes #69). Previous solution caused weird modal issues on pages where Magellan block was present and it assumed that foundation is available.

briancwald commented 6 years ago

I see the issue originally we had problems with around quick-edit seem to be fixed! however, it did introduce some issues with IPE.

1) When clicking 'edit' it does not attach Magellan back correctly.

magellan-1

2) similar to the first issue, if you are down the page, and 'edit' in IPE, it attaches to the top of the page always.

magellan-2

zolhorvath commented 6 years ago

so the sticky behavior also needs foundation to be destroyed :(