search

acquia / drupal-environment-detector

Provides common methods for detecting the current Acquia environment
GNU General Public License v2.0
10 stars 12 forks source link

fix stage env issue on ACE #12

Closed gauravgoyal closed 3 years ago

gauravgoyal commented 3 years ago

Fixes #

https://github.com/acquia/drupal-environment-detector/issues/11

Motivation

What problem does this solve? Why is it important? What's the context?

Acquia environment detector is being used to style toolbar based on the environment for easy detection. However it is not identifying stage environment properly. This PR fixes that issue.

Proposed changes

Changes isAhStageEnv() function to return TRUE if getAhEnv() return stage in staging environment.

Testing steps

  1. Goto ACE stage environment.
  2. Execute Acquia\DrupalEnvironmentDetector\AcquiaDrupalEnvironmentDetector:: isAhStageEnv(). It will return FALSE but expected is TRUE
  3. Print Acquia\DrupalEnvironmentDetector\AcquiaDrupalEnvironmentDetector::getAhEnv() and it should return stage.
danepowell commented 3 years ago

You can ignore the failing tests here, I'll fix them.