search

acquia / drupal-environment-detector

Provides common methods for detecting the current Acquia environment
GNU General Public License v2.0
10 stars 12 forks source link

Add Acquia Lando support #16

Closed grasmash closed 3 years ago

mikemadison13 commented 3 years ago

the previous iteration of this patch worked. the current version does not w/o me further modifying so that:

 /**
   * If this isn't a Cloud environment, assume it's local.
   */
  public static function isLocalEnv() {
    return !self::isAhEnv() || self::isAcquiaLandoEnv() || self::isLandoEnv();
  }

it seems that isLandoEnv works as expected but isAcquiaLandoEnv does not.

grasmash commented 3 years ago

@mikemadison13 What's the value of AH_SITE_ENVIRONMENT in your Lando env?

mikemadison13 commented 3 years ago

@grasmash it's reporting as LANDO.

grasmash commented 3 years ago

Fixed, maybe.

dhaggman commented 3 years ago

Can you do a tag release with this?

danepowell commented 3 years ago

Sure: https://github.com/acquia/drupal-environment-detector/releases/tag/v1.4.0