acquia / drupal-environment-detector

Provides common methods for detecting the current Acquia environment
GNU General Public License v2.0
10 stars 12 forks source link

Consider Cloud IDE is local. #30

Closed nikunjkotecha closed 2 years ago

nikunjkotecha commented 2 years ago

Fixes #21

Motivation

Details available in the issue.

Proposed changes

Any custom work done to make IDE work as local would need to be removed.

Alternatives considered

None

Testing steps

On Acquia Cloud IDE local.settings.php should be included.

danepowell commented 2 years ago

I appreciate the PR but we need to agree on an overall approach before jumping to an implementation. This could cause unexpected behavior for applications that don't currently consider IDE as local, i.e. if they are looking for AH settings in IDE