search

acquia / drupal-environment-detector

Provides common methods for detecting the current Acquia environment
GNU General Public License v2.0
10 stars 12 forks source link

Consider moving the BLT EnvironmentDetector into this library #33

Open jhedstrom opened 2 years ago

jhedstrom commented 2 years ago

There is some pretty useful additions the the environment detector, currently bundled within BLT, that would be nice to have in this project. The use case is for projects that are not using all of BLT, but would still like consistent detection across platforms.

There are probably some things in there that would need to remain BLT-specific, but most of the methods appear to be agnostic of BLT.

danepowell commented 2 years ago

I'm open to the idea, but could you be more specific about what you're interested in porting?

Most of the methods in BLT's detector are specific to certain environments (Pantheon, Travis, Pipelines, etc), or they deal with BLT-isms like detector overrides, and I'd prefer to exclude those from this library.

jhedstrom commented 2 years ago

The methods that initially made me realize it wasn't already part of this project were the Pantheon detection ones. Honestly I'd say any of the methods that only rely on this library could be moved here to allow broader use outside of BLT projects.

jonpugh commented 1 year ago

@jhedstrom @danepowell

I think we need a drupal/environment-detector that all the other environment detectors can extend.

A dev can dream....