acquia / drupal-spec-tool

A tool for specifying Drupal architecture details and generating automated tests for them.
GNU General Public License v2.0
149 stars 36 forks source link

Add Redirect options as columns to the Bundles tab #41

Open AllieRays opened 4 years ago

AllieRays commented 4 years ago

Description There are content types that never should be displayed with its own page, like an image media entity that's displayed in a carousel. Rabbit Hole can prevent this node from being accessible on its own page with the following options

I think this should be a standard and specified in the Drupal Spec tool. I made a copy of the Drupal spec tool excel book with the updates I think should be added. https://docs.google.com/spreadsheets/d/1muqPOBLFwr_PySl5OIbcWhrObGzs0yCamrJEGm_pBV8/edit?usp=sharing

Implementation

Columns that would need to be added to the Bundles tab. Column Redirect Behavior Redirect Override Redirect Path
note Redirect Module is Enabled Redirect Module is Enabled. If page redirect is selected, then allow these settings to be overridden for individual entities. If this is checked, users with the Administer Rabbit Hole settings for Content type permission will be able to override these settings for individual entities. Rabbit Hole is enabled. This is the path where nodes should be redirected. A good default would be /front.
data validation Page Redirect, Page not found, Display the page, Access denied y, n n/a
AllieRays commented 4 years ago

As discussed, I made an issue with the lightning core module to add Rabbit hole into the lighting distro. https://www.drupal.org/project/lightning_core/issues/3112048

TravisCarden commented 4 years ago

Thanks, @AllieRays. As I said when we discussed it, I support this, and I'll accept it if any of the following criteria are met:

(I should document that standard somewhere.)

Please let me know if you determine that any of those conditions attain. I'll bring your Lightning issue to the attention of the team.

TravisCarden commented 4 years ago

I brought it up to the Lightning team, @AllieRays, and they said they'd rather see this functionality go into Drupal core. Here's a d.o issue I created a couple of years ago which has a lot of overlap with which got a flash of attention at the time: Make the features of content, taxonomy, and blocks available à la carte [#2939529]. I would encourage you to file another issue to include Rabbit hole functionality in core and cross-link those issues. In the meantime, I would love to see PS adopt this as a best practice. If you'd like to start a conversation (with the tech leads?) I would be happy to weight in.