search

acquia / lightning-project

A Composer-based installer for the Lightning distribution of Drupal 8. Support ended on November 2, 2021 and this project is no longer maintained.
133 stars 60 forks source link

Remove .travis.yml after creating new project. #85

Closed danepowell closed 5 years ago

danepowell commented 6 years ago

Currently when you create a new project, you get a copy of lightning-project's .travis.yml. That seems like unneeded cruft for downstream projects. This removes .travis.yml after a project is initially created.

balsama commented 6 years ago

Great idea. It'd also be good to remove the dependency on Lightning Dev. +1 from me either way. We could do the lightning_dev dependency in a follow up.

danepowell commented 6 years ago

I added a step to remove lightning_dev. It's maybe not ideal, since you have to wait for composer to install it and then remove it--it would be nice if it never existed it the first place.

I'm actually not sure why lightning_dev exists in the first place if we're just going to remove it, is it for automated tests or something?

danepowell commented 6 years ago

I'm also not sure why tests are failing, the failures seem unrelated.

balsama commented 6 years ago

I'm also not sure why tests are failing, the failures seem unrelated.

Indeed. We need to get those fixed. Will prioritize today.

danepowell commented 6 years ago

After chatting with @phenaproxima, we decided to try a slightly different tack. Instead of distributing lightning_dev and forcing everyone to remove it after project creation, let's get it out of composer.json and just have the automated tests require it when necessary.

phenaproxima commented 6 years ago

I'm in favor of merging this when it's green on Travis.

balsama commented 5 years ago

Opened #92 to broaden the scope a bit.

phenaproxima commented 5 years ago

Fixed by #93.