acquia / moonshot

Moonshot: Because releasing services shouldn't be a moonshot!
Apache License 2.0
53 stars 49 forks source link

Option to suspend scaling operations during code deployment #112

Open pdrakeweb opened 8 years ago

pdrakeweb commented 8 years ago

It would be nice if there was an option to suspend scaling operations on the ASG during code deployment / stack update. It would also be nice if these operations could be suspended during initial deployment so that a long grace period is not required in order to use an ELB health check.

askreet commented 8 years ago

I wonder if this is as big of a concern as we think? From Health Checks for Auto Scaling Groups:

"Note that if you add a lifecycle hook to perform actions as your instances launch, the health check grace period does not start until the lifecycle hook is completed and the instance enters the InService state."

This should, in theory, include CodeDeploy -- so where have you seen that long health check grace periods are required?

pdrakeweb commented 8 years ago

This would be nice for development because if you deploy broken code (successful deploy, broken functionally) the ASG may terminate your instance shortly thereafter, making it difficult to debug. CodeDeploy will then proceed to deploy the broken code to every replacement instance, which the ASG will then proceed to terminate.