tanujjain49
commented
2 years ago MANUAL REVIEW
- Updating the moonshot gem.
2022-01-06 12:59:45 [cloudservicesdev|cloud-data:tanujjain] ~/Documents/github/acquia/cloud-database-worker$ git diff
diff --git a/Gemfile b/Gemfile
index 399baee..68fc232 100644
--- a/Gemfile
+++ b/Gemfile
@@ -52,8 +52,8 @@ group :development do
# @see https://github.com/acquia/moonshot/pull/245
# @see https://backlog.acquia.com/browse/CPD-3865
gem 'moonshot',
- git: 'git@github.com:acquia/moonshot.git',
- ref: 'proxy-cli-hook-aws-v2'
+ git: 'git@github.com:tanujjain49/moonshot.git',
+ ref: 'CPD-6858'
gem 'moonshot-production-safety',
git: 'git@github.com:acquia/cloud-moonshot-production-safety.git',
diff --git a/Gemfile.lock b/Gemfile.lock
index d178d59..b584d34 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -99,9 +99,23 @@ GIT
fpm (> 1.4)
GIT
- remote: git@github.com:acquia/moonshot.git
- revision: e7e923ca13440303cad6951944ead763bf2c54a7
- ref: proxy-cli-hook-aws-v2
+ remote: git@github.com:acquia/signalfx-bugsnag-middleware.git
+ revision: a5f1c13593888caf7002bfb011b3213057031ffb
+ ref: master
+ specs:
+ signalfx-bugsnag-middleware (0.1.0)
+
+GIT
+ remote: git@github.com:acquia/systemd-daemon.git
+ revision: 44623468b56dcd945242e313bef1cd6aeb48068b
+ ref: 0.0.1
+ specs:
+ systemd-daemon (0.1.0)
+
+GIT
+ remote: git@github.com:tanujjain49/moonshot.git
+ revision: bfd7dba55044f0d51ea0986539da4a1cd2da99f6
+ ref: CPD-6858
specs:
moonshot (2.0.0.beta6)
activesupport
@@ -119,20 +133,6 @@ GIT
travis
vandamme
-GIT
- remote: git@github.com:acquia/signalfx-bugsnag-middleware.git
- revision: a5f1c13593888caf7002bfb011b3213057031ffb
- ref: master
- specs:
- signalfx-bugsnag-middleware (0.1.0)
-
-GIT
- remote: git@github.com:acquia/systemd-daemon.git
2022-01-06 13:00:04 [cloudservicesdev|cloud-data:tanujj- Updating the
dev-tanujstage.2022-01-06 13:02:09 [cloudservicesdev|cloud-data:tanujjain] ~/Documents/github/acquia/cloud-database-worker$ bundle exec moonshot update -n dev-tanuj Using the Central Model for authentication Version 2 of the Ruby SDK will enter maintenance mode as of November 20, 2020. To continue receiving service updates and new features, please upgrade to Version 3. More information can be found here: https://aws.amazon.com/blogs/developer/deprecation-schedule-for-aws-sdk-for-ruby-v2/ [ ✓ ] [ 0m 0s ] Using existing KMS Key for ParameterKMS! [ ✓ ] [ 0m 1s ] Using previous encrypted value for NewRelicLicenseKey. [ ✓ ] [ 0m 8s ] ChangeSet moonshot-cdb-worker-dev-tanuj-1641454378 ready! * Modify LaunchConfig (AWS::AutoScaling::LaunchConfiguration) - Will be replaced - Caused by template change (Properties: ImageId) * Modify WorkerASG (AWS::AutoScaling::AutoScalingGroup) - May be replaced (Conditional) - Caused by LaunchConfig (ResourceReference) Apply changes? yes [ ✓ ] [ 0m 2s ] Executed ChangeSet moonshot-cdb-worker-dev-tanuj-1641454378 for CloudFormation Stack cdb-worker-dev-tanuj. [ ✓ ] [ 0m 30s ] CloudFormation Stack cdb-worker-dev-tanuj successfully updated. [ ✓ ] [ 0m 3s ] CodeDeploy Application cdb-worker-dev-tanuj already exists. [ ✓ ] [ 0m 0s ] CodeDeploy CodeDeploy Deployment Group cdb-worker-dev-tanuj already exists. [ ✓ ] [ 0m 6s ] AutoScaling Group(s) up to capacity! [ ✓ ] [ 0m 2s ] Uploading 'cdb-worker_1641454547_tanuj.jain.tar.gz' to 'cdb-stack-resource-backups-dev' succeeded. --> ASG desired capacity updated to 2. --> All instances cycled. --> ASG desired capacity updated to 1. [ ✓ ] [ 9m 3s ] ASG instances rotated successfully! 2022-01-06 13:14:55 [cloudservicesdev|cloud-data:tanujjain] ~/Documents/github/acquia/cloud-database-worker$
pdrakeweb
I want to see a manual review or a test covering these changes. Preferably reproducing the terminated instance issue.
Hint: we can just call moonshot update after making a change to worker template(eg: update ami) and that will trigger rotation of instances after stack update.