CPD-8525 | When in US regions, the api and worker should use AWS FIPS endpoints where available

acquia / moonshot

Moonshot: Because releasing services shouldn't be a moonshot!

Apache License 2.0

52 stars 49 forks source link

CPD-8525 | When in US regions, the api and worker should use AWS FIPS endpoints where available #310

Closed suvrat-joshi closed 6 months ago

suvrat-joshi commented 7 months ago

Motivation FIPS endpoint is only supported from aws-sdk v3 onwards so we have to upgrade the gem from v2 to v3.

Proposed changes Updates aws-sdk gem to v3

Alternatives considered N/A

Testing steps N/A

suvrat-joshi commented 6 months ago

This doesn't make us use the fips endpoints?

No, we need aws-sdk v3 for ruby for the FIPS endpoint, and this changes is for having moonshot compatible with the aws-sdk-ruby v3. Since all these are part of CPD-8525 ticket, hence I added it to the PR title. But this doesn't mandate FIPS endpoint.

stephenthedev commented 6 months ago

Merged thanks, made sure the commit message wasnt confusing 👍🏽