search

acquia / moonshot

Moonshot: Because releasing services shouldn't be a moonshot!
Apache License 2.0
52 stars 49 forks source link

Check S3 before building. #34

Open jamesiarmes opened 8 years ago

jamesiarmes commented 8 years ago

Issue by glennpratt Tuesday Oct 20, 2015 at 23:05 GMT Originally opened as https://github.com/acquia/cloud-moonshot/issues/14

Depends on #33 to be useful, with the project supplying a reliable version id that doesn't always rely on timestamp.

For deploy-code, check S3 before building and skip if it already does.

There should be a way to overwrite a build if somehow a bad build is pushed, probably build-code.

Could improve the "dev quickstart" time.

jamesiarmes commented 8 years ago

Comment by askreet Wednesday Oct 21, 2015 at 15:19 GMT

One blocker here is the ArtifactRepository's store hook isn't invoked until a build is done locally. You can do a deploy-version without doing a build today however I think the improvement in quickstart you're talking about comes from the creation of a stack not doing a full deploy-code, but instead using a deploy-version with a version built from master.

I think we need another pluggable component here, but I'm not sure what it is. Something like the deploy-code action asking a VersionProvider for the version number, then asking the ArtifactRepository if it's found. If not, it calls the BuildMechanism, then the ArtifactRepositories store action, before finally calling the DeploymentMechanism. If it does exist, it can skip directly to the DeploymentMechanism.