search

acquia / orca

A tool for testing a company's software packages together in the context of a realistic, functioning, best practices Drupal build
GNU General Public License v2.0
25 stars 21 forks source link

Change coverage clover to cobertura for Gitlab CI #484

Closed secretsayan closed 9 months ago

secretsayan commented 10 months ago

Related to https://github.com/acquia/orca/pull/483

The important change which would impact cover generation is already merged here https://github.com/acquia/orca/pull/483/commits/9e2000fffb169e5c149fedbe20ce32bf4fb48fc6 , this PR deals with mainly the variable names and text.

secretsayan commented 9 months ago

@TravisCarden : Please review the changes.

secretsayan commented 9 months ago

Looks pretty good, @secretsayan. Are we sure no one is using the current clover files? I seem to remember that we first introduced the $ORCA_COVERAGE_CLOVER environment variable at Matt Glaman's request. Please check with (at least) him to make sure we don't break anything he's depending on.

Yeah, now that I think of it, I think you are right, multiple projects are using ORCA_COVERAGE_CLOVER variable to specify the path to a clover file to generate coverage and it would be a breaking change for all those projects. Instead, we can keep both the variables ORCA_COVERAGE_CLOVER and ORCA_COVERAGE_COBERTURA so that ORCA users can define and use whichever they like. What to do you think?

secretsayan commented 9 months ago

@TravisCarden : I re-wrote the PR and added additional variables, please review when you can.

secretsayan commented 9 months ago

@TravisCarden : Ready for review.